Shape of Mind transparency? issues

jtothebell / fake-08

A Pico-8 player/emulator for console homebrew

Other

558 stars 49 forks source link

Shape of Mind transparency? issues #223

Closed briaguya-ai closed 7 months ago

briaguya-ai commented 7 months ago

Game: Shape of Mind

https://www.lexaloffle.com/bbs/?pid=shapeofmind
cart: https://www.lexaloffle.com/bbs/cposts/sh/shapeofmind-2.p8.png

fake-08 version

MiyooMini-libretro 0.0.2.20

Issue

Rotating "ribbon" around head doesn't appear transparent, seems to pick garbage values for color from placed pieces

Expected behavior

It appears as it does in browser at https://www.lexaloffle.com/bbs/?pid=shapeofmind

Experienced Behavior

shapeofmind-2 p8_000 shapeofmind-2 p8_001

DPS2004 commented 7 months ago

From a quick look it seems like the issue is in the prephalo function using the spritesheet as the drawing target and not clearing it properly? I'll do some poking around to see if i can narrow down the cause further

DPS2004 commented 7 months ago

Found a fix! Graphics::_private_h_line was not respecting the drawing target. I'll make a quick PR with this change.