search

jtoy / cld

compact language detection in ruby
BSD 3-Clause "New" or "Revised" License
210 stars 67 forks source link

compile for aarch64 #17

Closed lizthegrey closed 3 years ago

grosser commented 4 years ago

won't this break the old 32 bit build ?

jmgarnier commented 3 years ago

Hello @jtoy ,

Thank you @lizthegrey for pushing this PR. I am starting with my macbook M! on a new project using this gem and this PR is very welcomed.

And hello old internet firned @grosser ;)

Any chance this PR gets reviewed and a new release in the next months?

For the time being, I will try to fork it and publish an a gem

jmgarnier commented 3 years ago

https://github.com/akihikodaki/cld3-ruby could be used a replacement for this gem I guess

grosser commented 3 years ago

released as 0.9.0, lmk if that works

lizthegrey commented 3 years ago

Thanks! since I submitted this PR a year ago I have no idea if it's bitrotted but I guess we'll find out!

jmgarnier commented 3 years ago

It works like a charm 💐 on Apple silicon. Thank you!

jmgarnier commented 3 years ago

But it failed on CI on https://hub.docker.com/layers/ruby/library/ruby/3.0.2-alpine3.13/images/sha256-57ac5190124f0e637c63c42e8cc82c794e92bedfd494c69523ff71e60458921f?context=explore

Gem::Ext::BuildError: ERROR: Failed to build gem native extension.03:34
    current directory: /app/vendor/bundle/ruby/3.0.0/gems/cld-0.9.0/ext/cld03:34
/usr/local/bin/ruby -I /usr/local/lib/ruby/site_ruby/3.0.0 -r03:34
./siteconf20210715-1-ag6k1u.rb extconf.rb
checking build system type... Invalid configuration `x86_64-pc-linux-musl':03:34
machine `x86_64-pc-linux' not recognized03:34
configure: error: /bin/sh build_aux/config.sub x86_64-pc-linux-musl failed03:34
Makefile not found03:34
Gem files will remain installed in /app/vendor/bundle/ruby/3.0.0/gems/cld-0.9.003:34
for inspection.03:34
Results logged to03:34
/app/vendor/bundle/ruby/3.0.0/extensions/x86_64-linux-musl/3.0.0/cld-0.9.0/gem_make.out03:34
An error occurred while installing cld (0.9.0), and Bundler cannot continue.03:34
Make sure that `gem install cld -v '0.9.0' --source 'https://rubygems.org/'`03:34
succeeds before bundling.03:34
In Gemfile:03:35
  cld

Sorry about that, I guess I have broken lots of builds in the 🌍 ... Better to yank & revert, I will move to https://github.com/akihikodaki/cld3-ruby

grosser commented 3 years ago

thx, reverted+yanked ... lmt if you have an idea how to make it work for all :)