jtoy / sensenet

SenseNet is a sensorimotor and touch simulator for deep reinforcement learning research
Other
57 stars 20 forks source link

pip package for sensenet #31

Closed kiryteo closed 6 years ago

kiryteo commented 6 years ago

This remains to be uploaded on pypi.org

jtoy commented 6 years ago

can you commit the code that generates the package instead of the package? What command did you use to generate the package?

kiryteo commented 6 years ago

It required some changes with respect to setup.py, creating setup.cfg and further commands for packaging. I'll post the 'Making pip installable' text file here stating the commands required.

kiryteo commented 6 years ago

I have added the file mentioning all the steps taken in the process.

jtoy commented 6 years ago

I ran almost the sam instructions, but they dont work because the package is always missing this folder: https://github.com/jtoy/sensenet/tree/master/sensenet/envs/handroid/data

kiryteo commented 6 years ago

Did you try uploading the package I created on PyPI.? Does it give the same errors.?

jtoy commented 6 years ago

not yet because the modified build script is not included in the pull request, i want to rebuild it from scratch with your new code.

On Tue, Dec 26, 2017 at 1:38 PM, kiryteo notifications@github.com wrote:

Did you try uploading the package I created on PyPI.?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jtoy/sensenet/pull/31#issuecomment-353999471, or mute the thread https://github.com/notifications/unsubscribe-auth/AAA5v7e9eIGwy1K13QPxAHmxVRse76MMks5tET0qgaJpZM4RLpnE .

kiryteo commented 6 years ago

should I add the modified setup.py specifically.?

jtoy commented 6 years ago

yes please. Also I want to remove these 2 binaries from the pull request, we only need the source code, thank you!

jtoy commented 6 years ago

ill close this one for now, and we can just submit a new pull request with just the new setup.py

kiryteo commented 6 years ago

I'll add that asap.!

kiryteo commented 6 years ago

All right.