jtr13 / cc21fall1

Source files for EDAV Fall 2021 Mon / Wed Community Contribution Project
https://jtr13.github.io/cc21fall1
4 stars 67 forks source link

Neo4j init submission #22

Closed chaoyingzheng closed 2 years ago

ghost commented 2 years ago

Hi, please make the following corrections:

  1. All of the additional resources (not .Rmd file) should be in the resources// folder.
  2. The .Rmd filename can only contain lowercase letters. (Otherwise the filenames do not sort nicely on the repo home page.)
  3. The file should not contain a YAML header nor a --- line.
  4. The first line should start with a single hashtag #, followed by a single whitespace, and then the title.
  5. The second line should be blank, followed by the author name(s).
  6. Other hashtag headers should not be followed by numbers since the hashtags will create numbered subheadings. Correct: ## Subheading. Incorrect: ## 3. Subheading.
  7. The file should not contain any install.packages(), write functions, setwd(), or getwd(). (maybe put the install line as text instead of R code)
chaoyingzheng commented 2 years ago

Hi, all changes are made, please check. Thanks

ghost commented 2 years ago

Hi, thanks for making the changes.

One last thing; if you could change the following then it would all be good:

The first line should start with a single hashtag #, followed by a single whitespace, and then the title.

You can remove the title: and the quotes.

ghost commented 2 years ago

Hi, it seems that the file name changed back to the original name after this commit. Can you change it back with the following:

The .Rmd filename can only contain lowercase letters. (Otherwise the filenames do not sort nicely on the repo home page.)

chaoyingzheng commented 2 years ago

the file name is all lowercase on my local machine thought, not sure how to do that, any suggestion?

ghost commented 2 years ago

Great, thanks for your contribution!

ghost commented 2 years ago

@jtr13 Hi Dr. Robbins, just wanted to check in with you to review this pull request before merging!

jtr13 commented 2 years ago

@mtz2110 Looks great! 🚀

s10singh97 commented 2 years ago

@jtr13 Professor there is a problem with neo4j api and github actions. neo4j uses localhost with port 7474 which cannot be accessed by github actions in it's environment. There is a workaround to switch to neo4jshell but this would practically mean writing the complete code again. The build is failing because of this issue. Should we reopen the PR and request changes from the student? Or can we remove this from the _bookdown.yml file so that it does not get rendered for the time being so that other merges get reflected on the github pages successfully?

jtr13 commented 2 years ago

Yes, let's do that and then discuss later how to handle. Sorry I missed that!

jtr13 commented 2 years ago

I changed the approach to set eval=FALSE so that the chapter will still be included. See: https://github.com/jtr13/cc21fall1/issues/83