Closed chaoyingzheng closed 2 years ago
Hi, all changes are made, please check. Thanks
Hi, thanks for making the changes.
One last thing; if you could change the following then it would all be good:
The first line should start with a single hashtag #, followed by a single whitespace, and then the title.
You can remove the title: and the quotes.
Hi, it seems that the file name changed back to the original name after this commit. Can you change it back with the following:
The .Rmd filename can only contain lowercase letters. (Otherwise the filenames do not sort nicely on the repo home page.)
the file name is all lowercase on my local machine thought, not sure how to do that, any suggestion?
Great, thanks for your contribution!
@jtr13 Hi Dr. Robbins, just wanted to check in with you to review this pull request before merging!
@mtz2110 Looks great! 🚀
@jtr13 Professor there is a problem with neo4j api and github actions. neo4j uses localhost with port 7474 which cannot be accessed by github actions in it's environment. There is a workaround to switch to neo4jshell but this would practically mean writing the complete code again. The build is failing because of this issue. Should we reopen the PR and request changes from the student? Or can we remove this from the _bookdown.yml file so that it does not get rendered for the time being so that other merges get reflected on the github pages successfully?
Yes, let's do that and then discuss later how to handle. Sorry I missed that!
I changed the approach to set eval=FALSE
so that the chapter will still be included. See: https://github.com/jtr13/cc21fall1/issues/83
Hi, please make the following corrections: