search

jtr13 / cc21fall1

Source files for EDAV Fall 2021 Mon / Wed Community Contribution Project
https://jtr13.github.io/cc21fall1
4 stars 67 forks source link

introduction to flexdashboard and shiny #47

Closed 0506Zhengyi closed 2 years ago

0506Zhengyi commented 2 years ago

introduction to flexdashboard and shiny Yuezhu Xu and Zhengyi Fang

verlocks commented 2 years ago

Hi, please do the following:

jtr13 commented 2 years ago

@0506Zhengyi: It looks like you accidentally closed the PR -- I just reopened it. @verlocks: can you review and merge if all looks good? Thanks.

verlocks commented 2 years ago

@jtr13 Is that ok there is a .Rmd file in the Resources folder? Or we should delete it? I read the main .Rmd file and there is no connection to this .Rmd file in the Resources folder so it should be fine to just delete it. Other parts of it looks good to me, so once this settled, it should be able to be merged.

0506Zhengyi commented 2 years ago

hi @verlocks, the Rmd.file includes the codes for creating the dashboard. It is ok to delete it!

On Sun, Nov 21, 2021 at 2:27 AM verlocks @.***> wrote:

@jtr13 https://github.com/jtr13 Is that ok there is a .Rmd file in the Resources folder? Or we should delete it? I read the main .Rmd file and there is no connection to this .Rmd file in the Resources folder so it should be fine to just delete it. Other parts of it looks good to me, so once this settled, it should be able to be merged.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jtr13/cc21fall1/pull/47#issuecomment-974691628, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASP3OV2CYBHIOY2BZFF3AETUM7SCXANCNFSM5HOL7OKA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

verlocks commented 2 years ago

@0506Zhengyi good, then I'll just delete it and merge the request. Thanks for your contribution!