search

jtr13 / cc21fall1

Source files for EDAV Fall 2021 Mon / Wed Community Contribution Project
https://jtr13.github.io/cc21fall1
4 stars 67 forks source link

Community Contribution Group 6 #61

Closed gzmason closed 2 years ago

ShiyuWang88 commented 2 years ago

Please follow the below rules as said in the instructions:

  1. The .Rmd filename can only contain lowercase letters. (Otherwise the filenames do not sort nicely on the repo home page.)
  2. The first line should start with a single hashtag #, followed by a single whitespace, and then the title.
  3. The second line should be blank, followed by the author name(s).
ShiyuWang88 commented 2 years ago

@jtr13 Hi, Dr.Joyce: This one do have include resources/ in the file path to link to internal files but it has multiply links to the resources, I'd like to double check if this is appropriate?

jtr13 commented 2 years ago

It's ok to have multiple image files (as they do) but the .zip file is problematic. Those files should be in a separate repo with a link provided here to that repo.

gzmason commented 2 years ago

I changed the rmd file, deleted the zip file and made a new repo. Could you check again?

ShiyuWang88 commented 2 years ago

@jtr13 Hi, Dr.Joyce, Thanks for your reply. I have another question that whether it is fine to have capital letters in the branch name and the link to the resources?

jtr13 commented 2 years ago

Yes, that's fine. We're only concerned about the chapter file names so they sort nicely in the root directory of the repo.

ShiyuWang88 commented 2 years ago

@ejosied Hi, I see this community contribution has been labeled "Demonstration", I'd like to ask if there is supposed to be the a Demonstration part in our main bookdown yml since I have not find one in the main bookdown yml? Or should I attribute it to the Tutorial?

ejosied commented 2 years ago

@ShiyuWang88 Hi Shiyu, I have added the section to the bookdown file. Thanks for the reminder! Josie