search

jtr13 / cc21fall1

Source files for EDAV Fall 2021 Mon / Wed Community Contribution Project
https://jtr13.github.io/cc21fall1
4 stars 67 forks source link

Community Contribution #76

Closed Sarthak0211 closed 2 years ago

Sarthak0211 commented 2 years ago

CC for EDAV by Sarthak Bhargava and Arunit Maity

clarissarjtai commented 2 years ago

@Sarthak0211 PR should be submitted from a non-main branch instructions on how to fix the problem:

  1. Close this PR.
  2. Follow the instructions here for forgetting to branch if you committed and pushed to GitHub: https://edav.info/github#fixing-mistakes
  3. If you have trouble with 2., then delete the local folder of the project, delete your fork on GitHub, and start over. Open a new PR.
Sarthak0211 commented 2 years ago

Hi Clarissa

Apologies for the mistake. I am relatively new to GitHub so having a little trouble with it. I created a branch and submitted a pull request from there. Can you please check if this is correct? Again, I am really sorry for taking the extra time.

Best Sarthak Bhargava

On Sun, Nov 14, 2021 at 6:14 PM Clarissa RJ Tai @.***> wrote:

@Sarthak0211 https://github.com/Sarthak0211 PR should be submitted from a non-main branch instructions on how to fix the problem:

  1. Close this PR.
  2. Follow the instructions here for forgetting to branch if you committed and pushed to GitHub: https://edav.info/github#fixing-mistakes
  3. If you have trouble with 2., then delete the local folder of the project, delete your fork on GitHub, and start over. Open a new PR.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jtr13/cc21fall1/pull/76#issuecomment-968383125, or unsubscribe https://github.com/notifications/unsubscribe-auth/APJHA2RAKOSHXOLXG4Z2NCTUMA7DVANCNFSM5HPFEWLA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

clarissarjtai commented 2 years ago

Hi, @Sarthak0211

No worries! Hope you get familiar with the process. Here is a doc from Github, just to help you understand why branching is better to contribute: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-branches

I just rename the files and merge your pull request. Your page is quite simple and should not generate other problems. Thanks:)

Best, Clarissa