search

jtriley / pystun

A Python STUN client for getting NAT type and external IP
https://github.com/jtriley/pystun
MIT License
435 stars 154 forks source link

Fix infinite loop and nonType bug. #7

Open Feng-Zihao opened 10 years ago

Feng-Zihao commented 10 years ago

1, it's a logic bug in stun_test 2, there're stun implementation which do not have 'changed address' attribute in response. In this case, there's not enough evidence to judge NAT type.

jtriley commented 9 years ago

@Feng-Zihao Sorry but could you redo this PR against the latest develop branch? The master branch is for releases only. All PRs in the future should go to the develop branch. Thanks!