search

jtroo / kanata

Improve keyboard comfort and usability with advanced customization
GNU Lesser General Public License v3.0
3.18k stars 130 forks source link

Map `OsCode::KEY_YEN` with `KeyCode::Intl3` #1200

Closed nanikamado closed 3 months ago

nanikamado commented 3 months ago

Describe your changes. Use imperative present tense.

Map OsCode::KEY_YEN with KeyCode::Intl3

Checklist

nanikamado commented 3 months ago

This fixes a issue where trying to output KEY_YEN result in KEY_UNKNOWN.

Here is the config and input where this issue occurs: https://jtroo.github.io?data=BQEwpgZgzgTgxgAgIYEoBQpIBskE8wwLgRICuWALmgggKVooA+zLrbjIAXANJi4CCCCpwCcAFgSkefQcJEAGRUA

This is the log when this issue occurred:

16:01:39.4664 [INFO] kanata v1.7.0-prerelease-1 starting
16:01:39.4665 [INFO] process unmapped keys: false
16:01:39.4665 [DEBUG] (1) kanata_parser::cfg::alloc: freeing allocations of length 0
16:01:39.4665 [INFO] config file is valid
16:01:39.4671 [INFO] Created device "/dev/input/event7"
16:01:39.4671 [INFO] entering the processing loop
16:01:39.4672 [INFO] entering the event loop
16:01:39.4672 [INFO] looking for devices in /dev/input
16:01:39.4672 [TRACE] (1) kanata_state_machine::oskbd::linux: [src/oskbd/linux.rs:261] Detected other device: Power Button
16:01:39.4672 [INFO] Starting kanata proper
16:01:39.4673 [INFO] You may forcefully exit kanata by pressing lctl+spc+esc at any time. These keys refer to defsrc input, meaning BEFORE kanata remaps keys.
16:01:39.4829 [TRACE] (1) kanata_state_machine::oskbd::linux: [src/oskbd/linux.rs:261] Detected other device: Lid Switch
16:01:39.5020 [TRACE] (1) kanata_state_machine::oskbd::linux: [src/oskbd/linux.rs:261] Detected other device: Sleep Button
16:01:39.5219 [DEBUG] (1) kanata_state_machine::oskbd::linux: Detected Keyboard: name=AT Translated Set 2 keyboard physical_path=Some("isa0060/serio0/input0")
16:01:39.5220 [DEBUG] (1) kanata_state_machine::oskbd::linux: Detected Mouse: name=DLL0B47:01 06CB:CE8C Mouse physical_path=Some("i2c-DLL0B47:01")
16:01:39.5220 [TRACE] (1) kanata_state_machine::oskbd::linux: [src/oskbd/linux.rs:261] Detected other device: DLL0B47:01 06CB:CE8C Touchpad
16:01:39.5409 [TRACE] (1) kanata_state_machine::oskbd::linux: [src/oskbd/linux.rs:261] Detected other device: Video Bus
16:01:39.5590 [TRACE] (1) kanata_state_machine::oskbd::linux: [src/oskbd/linux.rs:261] Detected other device: DELL Wireless hotkeys
16:01:39.5789 [TRACE] (1) kanata_state_machine::oskbd::linux: [src/oskbd/linux.rs:261] Detected other device: PC Speaker
16:01:39.6169 [TRACE] (1) kanata_state_machine::oskbd::linux: [src/oskbd/linux.rs:261] Detected other device: Dell WMI hotkeys
16:01:39.6349 [TRACE] (1) kanata_state_machine::oskbd::linux: [src/oskbd/linux.rs:261] Detected other device: HD-Audio Generic HDMI/DP,pcm=3
16:01:39.6559 [TRACE] (1) kanata_state_machine::oskbd::linux: [src/oskbd/linux.rs:261] Detected other device: HD-Audio Generic HDMI/DP,pcm=7
16:01:39.6819 [TRACE] (1) kanata_state_machine::oskbd::linux: [src/oskbd/linux.rs:261] Detected other device: HD-Audio Generic Headphone Mic
16:01:39.7199 [TRACE] (1) mio::poll: [/home/mado/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-0.8.11/src/poll.rs:551] registering event source with poller: token=Token(0), interests=READABLE
16:01:39.7200 [INFO] registering /dev/input/event3: "AT Translated Set 2 keyboard"
16:01:39.7409 [TRACE] (1) mio::poll: [/home/mado/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-0.8.11/src/poll.rs:551] registering event source with poller: token=Token(1), interests=READABLE
16:01:39.7409 [INFO] registering /dev/input/event4: "DLL0B47:01 06CB:CE8C Mouse"
16:01:39.7639 [TRACE] (1) mio::poll: [/home/mado/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-0.8.11/src/poll.rs:551] registering event source with poller: token=Token(2), interests=READABLE
16:01:39.7639 [TRACE] (1) kanata_state_machine::oskbd::linux: [src/oskbd/linux.rs:130] polling
16:01:39.7640 [TRACE] (3) kanata_state_machine::kanata: [src/kanata/mod.rs:1743] blocking on channel
16:01:49.7471 [TRACE] (1) kanata_state_machine::kanata::linux: [src/kanata/linux.rs:42] [InputEvent { time: SystemTime { tv_sec: 1723705309, tv_nsec: 746999000 }, kind: Misc(MSC_SCAN), value: 125 }, InputEvent { time: SystemTime { tv_sec: 1723705309, tv_nsec: 746999000 }, kind: Key(KEY_YEN), value: 1 }, InputEvent { time: SystemTime { tv_sec: 1723705309, tv_nsec: 746999000 }, kind: Synchronization(SYN_REPORT), value: 0 }]
16:01:49.7472 [TRACE] (1) kanata_state_machine::oskbd::linux: [src/oskbd/linux.rs:130] polling
16:01:49.7473 [DEBUG] (3) kanata_state_machine::kanata: process recv ev KeyEvent { code: KEY_YEN (124), value: Press }
16:01:49.7474 [TRACE] (3) kanata_state_machine::kanata: [src/kanata/mod.rs:1029] []
16:01:49.7474 [TRACE] (3) kanata_state_machine::kanata: [src/kanata/mod.rs:1072] [No]
16:01:49.7474 [DEBUG] (3) kanata_state_machine::kanata: key press     No
16:01:49.7474 [DEBUG] (3) kanata_state_machine::oskbd::linux: send to uinput: InputEvent { time: SystemTime { tv_sec: 0, tv_nsec: 0 }, kind: Key(KEY_UNKNOWN), value: 1 }
16:01:49.7475 [TRACE] (3) kanata_state_machine::kanata: [src/kanata/mod.rs:1743] blocking on channel
16:01:49.8322 [TRACE] (1) kanata_state_machine::kanata::linux: [src/kanata/linux.rs:42] [InputEvent { time: SystemTime { tv_sec: 1723705309, tv_nsec: 832132000 }, kind: Misc(MSC_SCAN), value: 125 }, InputEvent { time: SystemTime { tv_sec: 1723705309, tv_nsec: 832132000 }, kind: Key(KEY_YEN), value: 0 }, InputEvent { time: SystemTime { tv_sec: 1723705309, tv_nsec: 832132000 }, kind: Synchronization(SYN_REPORT), value: 0 }]
16:01:49.8323 [TRACE] (1) kanata_state_machine::oskbd::linux: [src/oskbd/linux.rs:130] polling
16:01:49.8324 [DEBUG] (3) kanata_state_machine::kanata: process recv ev KeyEvent { code: KEY_YEN (124), value: Release }
16:01:49.8325 [TRACE] (3) kanata_state_machine::kanata: [src/kanata/mod.rs:1029] [No]
16:01:49.8325 [DEBUG] (3) kanata_state_machine::kanata: key release   No
16:01:49.8325 [DEBUG] (3) kanata_state_machine::oskbd::linux: send to uinput: InputEvent { time: SystemTime { tv_sec: 0, tv_nsec: 0 }, kind: Key(KEY_UNKNOWN), value: 0 }
16:01:49.8326 [TRACE] (3) kanata_state_machine::kanata: [src/kanata/mod.rs:1072] []
16:01:49.8326 [TRACE] (3) kanata_state_machine::kanata: [src/kanata/mod.rs:1743] blocking on channel
jtroo commented 3 months ago

Thanks!