search

jts / sga

de novo sequence assembler using string graphs
http://genome.cshlp.org/content/22/3/549
237 stars 82 forks source link

set language standard #126

Closed mateidavid closed 8 years ago

mateidavid commented 8 years ago

I reverted the getline modifications (which were not comprehensive), and instead set the entire language standard to c++98/gnu99. I added a build testing Dockerfile, which currently works with gcc-6.1.1. Note, the gcc6 fix for BamTools is not yet present in the latest tagged release (2.4.0), so BamTools must be installed with git clone instead of wget.

wookietreiber commented 8 years ago

As mentioned in #122 I would prefer not going backwards with the C/C++ standards.

mateidavid commented 8 years ago

Setting a specific language standard during compilation amounts to acknowledging the dialect that was used to write the program in the first place. The reason the standard is not currently set during compilation is because back then, there was only one unambiguous C++ standard, c++98/gnu++98. Recent language updates (C++11, C++14) introduce occasionally incompatible changes. What value do you see in updating a software package to work with a new standard, if 1) it works just fine with an old standard and 2) modern compilers know about old standards?

wookietreiber commented 8 years ago

I can live with that reasoning. LGTM.