jtsage / jtsage-datebox

A multi-mode date and time picker for Bootstrap (3&4), jQueryMobile, Foundation, Bulma, FomanticUI, and UIKit (or others)
http://datebox.jtsage.dev/
Other
474 stars 166 forks source link

ui-focus is not correctly applied with jqm 1.3+ #270

Closed jnyrup closed 11 years ago

jnyrup commented 11 years ago

When using jqm 1.3.1+ a datebox is wrapped inside an extra div. This causes .ui-focus to be applied to the wrong element, when focusing a datebox.

Without knowing the exact scope of w.d.wrap in _create, .parent() could be added to w.d.wrap for both oldStyle and newStyle to reference the right element.

jtsage commented 11 years ago

Closed with SHA: 303808e5e11a64dbddab44464d3a1cf414749d31

jnyrup commented 11 years ago

There are unfortunately still some issues with focus: See this example: http://jsfiddle.net/QdVvZ/ Click anywhere on the first datebox to see the focus jumping around. Click on the icon on the second datebox and when the calendar pops up, the focus wrong.

jtsage commented 11 years ago

damn. ok, working on it.

jnyrup commented 11 years ago

The second datebox now works perfect, but the first one still has an issue with focus switching between the inner and outer div, at least for me. I'm using Linux Mint 15 mate + Chrome 28.0.1500.52

jtsage commented 11 years ago

You mean the quite obvious pause between it "fixing" itself? Yeah, forgot I hacked that in - I'll try and truly fix it today...

jnyrup commented 11 years ago

Yeah, that pause. (Even though it does go: right => wrong => right)

... and nice to see that the projects is getting in shape again :)

jnyrup commented 11 years ago

Perhaps this issue should be reopened?