search

jtsage / jtsage-datebox

A multi-mode date and time picker for Bootstrap (3&4), jQueryMobile, Foundation, Bulma, FomanticUI, and UIKit (or others)
http://datebox.jtsage.dev/
Other
474 stars 166 forks source link

Russian i18n fixes #353

Closed slavap closed 10 years ago

slavap commented 10 years ago

Looks like it was translated by some king of automatic translation tool, some items are really funny :-)

  1. "tooltip": "Открытый выбор даты" must be "Открыть выбор даты"
  2. "timeFormat": 12 should be 24 because in Russia it's like US military time.
  3. "dateFieldOrder - not sure what exactly that means, but for RU it should be "d", "m", "y" (day month year). The same for "dateFormat": "%-m/%-d/%Y" must be "%-d.%-m.%-Y"
  4. "calStartDay": 0 must be 1 (Monday)
  5. "clearButton": "Ясно" must be "Очистить"

And question. Why jquery.mobile.datebox.i18n.en_US.utf8.js was not updated on "cdn repo" ? Looks like it's obsolete and jquery.mobile.datebox.i18n.en.utf8.js must be used instead. Then it's good idea to delete jquery.mobile.datebox.i18n.en_US.utf8.js from cdn.

jtsage commented 10 years ago

Heh. As it happens, I think the vast majority of the translations were done by a machine - at least in part. I'll push your corrections in shortly.

As far as en_US, as I remember, it was originally just a copy of en with a different date format - but it looks like you are right, and it is obsolete - I'll likely just link it to "en" so as not to break any old links.

Thanks!

jtsage commented 10 years ago

Re-symlinked en_US to vanilla en. (Preserve links I suppose)

jtsage commented 10 years ago

1.) corrected 2.) this was a build system error 3.) same as #2, date format updated for no zero padding 4.) corrected 5.) corrected