search

jtsalva / cloudmare

Cloudflare Manager | Android Mobile App
https://cloudmare.jtsalva.dev
MIT License
43 stars 12 forks source link

Delete a useless line #18

Closed yzqzss closed 3 years ago

yzqzss commented 4 years ago

It seems that if this useless line not deleted, this string.xml will not be added to the installation package when compiling. Then there will be no Chinese translation in the software.

jtsalva commented 3 years ago

@yzqzss please can you clarify what the issue is with the deleted line? I can see that in strings.xml that line doesn't exist so am happy to merge, however, I seem to be compiling fine and seeing the Chinese translation working as expected.

How can I reproduce?

yzqzss commented 3 years ago

I compiled it again. Found that this line did not cause any compilation problems. Maybe it’s just my compilationg configuration problem before. Anyway, you can use HEX EDITOR to see the line.