Feature Request: iframe and JS embeds

jtsternberg / Code-Snippets-CPT

A WordPress plugin for managing and displaying code snippets

http://dsgnwrks.pro

19 stars 17 forks source link

Feature Request: iframe and JS embeds #8

Open jaredatch opened 9 years ago

jaredatch commented 9 years ago

Great work.

I'm a big user of gist. To me, the biggest features needed in order to ditch gist are the ability to embed code snippets off site via iframes and JS embeds.

If memory serves correct I think Capsule (https://github.com/crowdfavorite/wp-capsule/) had the js embed feature figured out.

I think it would be cool to have some sort of API to do this. /raw, /js, /iframe or something of that nature.

Anyways, just a few ideas. Keep up the great work. Once a few more features are added I'd definitely try to ditch gist for this :)

jtsternberg commented 8 years ago

I love this idea. I'm curious if the oembed stuff they added to WP core could be modified for snippets. That would be pretty sweet to have built-in oembed support!

jtsternberg commented 8 years ago

Some notes from @JustinSainton and I brainstorming:

WordPress filter for messing w/ oembed data before sending: https://github.com/WordPress/WordPress/blob/51579c49a8db85aeb1a03aaeee9a0844ea04bb70/wp-includes/embed.php#L545
To calculate the height, we'd likely need to, on the snippet-edit side, do a JS ajax request to fetch the front-end view and calculate the height and store as post-meta (do the request on submit, debounced, with each edit/keystroke).
height, I think will work by simply specifying 100%

ramiabraham commented 8 years ago

I love this idea.

Some thoughts:

rest api; along with a register_rest_route() endpoint, this could provide json to the oEmbed. Could reduce work needed for client side, and also provides the opportunity to place a WP_Rest_Repsone object caching layer between things.
the new template hierarchy components for oEmbeds are neat.