search

jtsternberg / DsgnWrks-Instagram-Importer

Backup your instagram photos & display your instagram archive. Supports importing to custom post-types & adding custom taxonomies.
http://wordpress.org/extend/plugins/dsgnwrks-instagram-importer/
33 stars 16 forks source link

Carousel -> future #46

Closed nfriedly closed 6 years ago

nfriedly commented 6 years ago

This is a clone of #45 targeted at the branch future

I had to handle one merge conflict around line 1183 where it adds the insta-moderation links, so please give that a little extra scrutiny.

If you hide whitespace changes, it becomes a little more apparent what I actually did: https://github.com/jtsternberg/DsgnWrks-Instagram-Importer/pull/46/files?utf8=%E2%9C%93&diff=split&w=1

nfriedly commented 6 years ago

I'm thinking that I'm going to change the behavior of upload_media() to return some metada instead of HTML. I'll probably move the html snippet generation to a new method and call that from pic_loop() with the metadata.

My reasoning, besides feeling a bit cleaner, is that this will enable a bit more flexibility with what data is passed to the templates and/or stored in the post metadata. In particular, I want an array of objects for the carousel, where each object includes all of the attachment ids for one pic/video (standard and low-rez video, screenshot, thumbnail, etc.)

Any thoughts?

jtsternberg commented 6 years ago

Regarding this PR, first I have to apologize because I told you to branch of the future branch to make your changes, but didn't realize I hadn't pushed my recent changes, which are the ones wich introduced the carousel feature. Can you please pull down a fresh copy of future and do some testing to see what of your PR still needs to be added?

nfriedly commented 6 years ago

Aah, that makes sense. No worries though.

I'm out on a work trip right now, so it'll probably a week or so, but I'll pull in the latest changes and see what's still needed.

jtsternberg commented 6 years ago

Closing this per https://github.com/jtsternberg/DsgnWrks-Instagram-Importer/pull/45#issuecomment-431079650