Closed nfriedly closed 6 years ago
Beautiful. We should discuss co-maintainership. Are you open to the idea?
Yea, I'm happy to help out. It's been quite a while since I've done any php, but it seems like WordPress is pretty adamant about supporting older versions, so I'm not missing much in this context.
No rush on this. I thought you might appreciate it, though, and it'll certainly make me feel a little more confident about my PRs.
This includes a few changes to test against current versions of PHP and avoid incompatibilities:
mysql_connect()
, which was removed in PHP 7.0With these changes, you now have a green build - see https://travis-ci.org/nfriedly/DsgnWrks-Instagram-Importer/builds/431689310
I structured things so that current-gen stuff is the "default" and legacy stuff is added to the matrix one-at-a-time. It's a little verbose, but it has a benefit of allowing you to add future versions of PHP and WordPress without having to remember to exclude the legacy stuff.
I'm targeting this PR at
future
but it should be easy enough to cherry-pick ontomaster
if you'd like, especially if you squash-and-merge.