jtsternberg / DsgnWrks-Instagram-Importer

Backup your instagram photos & display your instagram archive. Supports importing to custom post-types & adding custom taxonomies.
http://wordpress.org/extend/plugins/dsgnwrks-instagram-importer/
33 stars 16 forks source link

Fix Travis CI #47

Closed nfriedly closed 6 years ago

nfriedly commented 6 years ago

No rush on this. I thought you might appreciate it, though, and it'll certainly make me feel a little more confident about my PRs.

This includes a few changes to test against current versions of PHP and avoid incompatibilities:

With these changes, you now have a green build - see https://travis-ci.org/nfriedly/DsgnWrks-Instagram-Importer/builds/431689310

I structured things so that current-gen stuff is the "default" and legacy stuff is added to the matrix one-at-a-time. It's a little verbose, but it has a benefit of allowing you to add future versions of PHP and WordPress without having to remember to exclude the legacy stuff.

I'm targeting this PR at future but it should be easy enough to cherry-pick onto master if you'd like, especially if you squash-and-merge.

jtsternberg commented 6 years ago

Beautiful. We should discuss co-maintainership. Are you open to the idea?

nfriedly commented 6 years ago

Yea, I'm happy to help out. It's been quite a while since I've done any php, but it seems like WordPress is pretty adamant about supporting older versions, so I'm not missing much in this context.