Closed amintorres closed 10 years ago
It looks like the pdp url is being inserted twice on the tweet.
I think we should stick to just twiter and facebook for these sharing. If we are going to leave email, lets then at least populate the FROM field as well as the Subject field with : "Check out this cool photo on 2by2" But again, I much rather not use this emailing function.
Let's remove print for sure. not adding any value. I just try to print and instead saved the PDF to my desktop to see what the print out would look like and its just horrible. Not to mention, by doing this we are letting users download the photo of other people. (github does not support PDF attachments here so will save to dropbox so you can seee)
Nevermind all that crap I just wrote about, lets use this: https://developers.facebook.com/docs/plugins/like-button/ The standard button.
With the share a link "tweet" button: https://about.twitter.com/resources/buttons First one here.
See psd here for reference. /2by2/_web/PDP_LoggedIn.psd
How about tumblr?
Sent from my mobile device
On Apr 18, 2014, at 7:12 AM, "Amin Torres" notifications@github.com wrote:
I think we should stick to just twiter and facebook for these sharing. If we are going to leave email, lets then at least populate the FROM field as well as the Subject field with : "Check out this cool photo on 2by2" But again, I much rather not use this emailing function.
— Reply to this email directly or view it on GitHub.
is it possible to align them? :(
I don't think so, since they are embeded...but let me check
this is a pain in the butt
Nice find, done.
Also added it to the profile page :)
And for tumblr it adds who took the photo too
Let's add some sharing sugar to the pdp on web.