jtushman / state_machine

Python State Machine for humans
MIT License
400 stars 31 forks source link

Run tests on Python 3.3/2.7/PyPy with Tox, run tests on Travis #11

Closed daxtens closed 10 years ago

daxtens commented 10 years ago

This just takes your existing tests and runs them:

It depends on my previous Python 3 pull request, sorry. If that's a problem I can disaggregate them.

jtushman commented 10 years ago

This looks great -- will hit this tomorrow AM. I will also look hooking up travisci.org Does their open soruce version support Mongo? (no need to really answer that -- I'll look into it in the morning).

Really excited about the 3.3 support.

Thanks for being involved and taking an interest

daxtens commented 10 years ago

Yes - travis does support MongoDB: http://docs.travis-ci.com/user/database-setup/. The .travis.yml file runs the tests with both mongoengine and sqlalchemy.

jtushman commented 10 years ago

Merged - and configured and I threw the build-status badge on the read me. Boom!

jtushman commented 10 years ago

So the tests are passing -- though with 2.7 -- it looks like travis is not cleaning up successfully or something. Take a look: https://travis-ci.org/jtushman/state_machine/jobs/21177524

Any ideas?

daxtens commented 10 years ago

Yeah, it's a bug in Python 2 that was fixed in 2.7.4 (http://bugs.python.org/issue15881#msg170215) and travis is still using 2.7.3.

The good news is that it's harmless.

jtushman commented 10 years ago

Cool -- thanks man