search

jtushman / state_machine

Python State Machine for humans
MIT License
400 stars 31 forks source link

Your code is too weak for PEP8. You lack DISCIPLINE #5

Closed pyarnold closed 10 years ago

pyarnold commented 10 years ago

Good morning how are you? This is Arnold! Nice to meet you. I like your project, but your code looks gurly and lacks discipline! Here is a pull request to pump it up. You must apply it, do it now!

Since Maria kicked me out, I've been teaching myself Python and going to Gold's Gym of course. I think you mean well, but you are using Python like Java. Java is weak! You can make your Python code so much buffer by making it pythonic.

I hope to see you at Gold's!

jtushman commented 10 years ago

Thanks Pyarnold -- I actually fixed a bunch of these on a branch that I just merged in. Your PR is out of date now. I am going to close it -- but you can open a new one with pep8 goodness if I still need to hit the gym

Thanks!