jtv / libpqxx

The official C++ client API for PostgreSQL.
http://pqxx.org/libpqxx/
BSD 3-Clause "New" or "Revised" License
1.01k stars 237 forks source link

building fail on github actions using cmake 3.30 #863

Closed dr3mro closed 3 weeks ago

dr3mro commented 1 month ago

Unknown CMake command "cmake_determine_compile_features". thats all, looks like cmake has changed a method name https://gitlab.kitware.com/cmake/cmake/-/merge_requests/9366

please fix

tt4g commented 1 month ago

Thank you for reporting, this problem already fixed #851 but not release yet). Workaround use fixed source (fixed in d5bf7cf83d0c86c502b6b30d5f0c8dc3b3049a38).

jtv commented 1 month ago

@dr3mro does the latest master fix it?

jlnr commented 1 month ago

libpqxx 7.9.1 stopped compiling for me with the same error after both Homebrew and my Linux distro upgraded CMake to version 3.30. I can confirm that it is fixed on the latest master commit.

An official release that contains the fix would be greatly appreciated, because then package managers like Conan will pick it up.

% git checkout tags/7.9.1
% cmake ..                
CMake Error at cmake/config.cmake:14 (include):
  include could not find requested file:

    CMakeDetermineCompileFeatures
Call Stack (most recent call first):
  CMakeLists.txt:27 (include)

-- Found PostgreSQL: /opt/homebrew/lib/postgresql@14/libpq.dylib (found version "14.12")
-- Looking for poll
-- Looking for poll - found
CMake Error at cmake/config.cmake:42 (cmake_determine_compile_features):
  Unknown CMake command "cmake_determine_compile_features".
Call Stack (most recent call first):
  CMakeLists.txt:27 (include)

-- Configuring incomplete, errors occurred!

% git checkout master     
Previous HEAD position was c154460e Disable clang-based parsing in Doxygen. (#847)
Switched to branch 'master'
Your branch is up to date with 'origin/master'.
% cmake ..               
-- Generating config.h
-- Generating config.h - done
-- Configuring done (2.9s)
-- Generating done (0.0s)
-- Build files have been written to: [redacted]/build
jtv commented 1 month ago

OK, coming up!

jtv commented 3 weeks ago

@jlnr did the release solve your problem?

dr3mro commented 3 weeks ago

@jlnr did the release solve your problem?

yeah

jtv commented 3 weeks ago

Okay, when we can close this ticket.