jtwotimes / PokeApiNet

.Net wrapper for the Pokemon API PokeAPI
MIT License
104 stars 38 forks source link

Pokemon Species missing IsLegendary and IsMythical #25

Closed konvay closed 3 years ago

konvay commented 3 years ago

The PokemonSpecies object is missing these two fields. The additional fields can be seen on the PokeApi GET /pokemon-species/{name or id}/ route.

https://pokeapi.co/api/v2/pokemon-species/ditto

konvay commented 3 years ago

I have the fields added in a local branch, but can't I push my branch to this repo. It's pretty small:

        /// <summary>
        /// Whether or not this is a legendary Pokémon.
        /// </summary>
        [JsonProperty("is_legendary")]
        public bool IsLegendary { get; set; }

        /// <summary>
        /// Whether or not this is a mythical Pokémon.
        /// </summary>
        [JsonProperty("is_mythical")]
        public bool IsMythical { get; set; }
jtwotimes commented 3 years ago

Thanks for finding this.

Feel free to fork this repo and push a PR so I can review and add this in, or I can make a release with this change in the next day or so.

For my own reference: here's the code that added those fields.

konvay commented 3 years ago

Awesome, here's the PR

https://github.com/mtrdp642/PokeApiNet/pull/26

konvay commented 3 years ago

Merged 👍