White space at the bottom of the Game screen

[patsej]

A space appears now at the bottom of the Game page, above the buttons

It has been introduced by the commit Fixed style issues on the game page

Due to box-sizing: unset !important; commented out in treasure.css

*,
*::before,
*::after {
   /* box-sizing: unset !important; */
}

Why was it necessary?

Replacing if by the following code works

div#mappage {
    box-sizing: unset !important;
}

I haven't seen any regression. Could you also check please?

Note: I've included this patch in the "Fix Simple question's answer layout" PR.

[juacas]

Merged into develop branch. Thanks! 👍

[patsej]

Great, thanks! 😁

On Fri, Feb 14, 2020, 09:25 Juan Pablo de Castro notifications@github.com wrote:

Merged into develop branch. Thanks! 👍

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/juacas/moodle-mod_treasurehunt/issues/35?email_source=notifications&email_token=AAXP3DDNOZ5OW3FCDZLVIDDRCZIRNA5CNFSM4KUVM7B2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELX7FLY#issuecomment-586150575, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXP3DDD3J4GU4A4PSZRW33RCZIRNANCNFSM4KUVM7BQ .

[patsej]

I've tried to remove the !important in the definition of div#mappage. I noticed no difference. Do you know if it is mandatory for another theme or if there is a case where it's useful? If not, it would be better to remove it :-)

[patsej]

BTW, do you know if there is a way to get rid of the scrollbar that appears to the right?

[juacas]

Sorry but, there is no scrollbar in any of my tests/devices.

[patsej]

That's a good news :-D It's not a problem. It's on Firefox. On Chrome the scrollbar does not appear.