juami / pytentiostat

python code for the JUAMI potentiostat

BSD 3-Clause "New" or "Revised" License

9 stars 13 forks source link

Update logo and icon #101

Closed mspence2 closed 4 years ago

mspence2 commented 5 years ago

changed the image files for the logo and added bookmark icon. Files from 10/21 are most up-to-date as of 10/29.

codecov-io commented 5 years ago

Codecov Report

Merging #101 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #101   +/-   ##
=======================================
  Coverage   70.95%   70.95%           
=======================================
  Files           8        8           
  Lines         210      210           
=======================================
  Hits          149      149           
  Misses         61       61

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 53a25f4...801d36b. Read the comment docs.

jlhitt1993 commented 4 years ago

I think this one is ready to pull

sbillinge commented 4 years ago

Let’s work on a release. I think we have all the pieces....

On Thu, Mar 19, 2020 at 8:49 PM Jeremy Hitt notifications@github.com wrote:

I think this one is ready to pull

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/juami/pytentiostat/pull/101#issuecomment-601481323, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAOWUOLJD446DQHKMURGB3RIK4SHANCNFSM4JGR7IRQ .

-- Professor Simon Billinge Columbia University

jlhitt1993 commented 4 years ago

We are still missing some documentation. Maybe we can at least add some install instructions before.

sbillinge commented 4 years ago

we started to use milestones, but if we are serious about a release, on a particular date, we should make a milestone, make issues, attach them to the milestone, assign them to people and then close them on time..... It's the only way I am afraid....

mspence2 commented 4 years ago

The sphinx theme for this is different from what we have committed to in the main repo. I will close this and worry about adding the logos in the new theme.