juami / pytentiostat

python code for the JUAMI potentiostat

BSD 3-Clause "New" or "Revised" License

9 stars 13 forks source link

Fix requirements #118

Closed sbillinge closed 5 years ago

sbillinge commented 5 years ago

@chiahaoliu please could you review this and merge. Then we will need to make a new release (could you do that) and redo the conda staged recipe. I think the requirements need to be updated for it to pass CI on conda-forge (not sure still struggling with it)

codecov-io commented 5 years ago

Codecov Report

Merging #118 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   70.69%   70.69%           
=======================================
  Files           8        8           
  Lines         215      215           
=======================================
  Hits          152      152           
  Misses         63       63

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0e8ebae...fecf643. Read the comment docs.

chiahaoliu commented 5 years ago

@sbillinge It looks good to me!

sbillinge commented 5 years ago

Thanks @chiahaoliu We seem to have accidentally bumped it from 0.0.3 to 0.0.5, but no big deal.

On Sat, Nov 23, 2019 at 8:46 PM Timothy Liu notifications@github.com wrote:

Merged #118 https://github.com/juami/pytentiostat/pull/118 into master.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/juami/pytentiostat/pull/118?email_source=notifications&email_token=ABAOWUMN7JGYUIVIHWXQNTTQVHMHTA5CNFSM4JQ3RYC2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVBWJVHA#event-2825689756, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAOWULXO5KXRV7XJ6L5OCTQVHMHTANCNFSM4JQ3RYCQ .