search

juami / pytentiostat

python code for the JUAMI potentiostat
BSD 3-Clause "New" or "Revised" License
9 stars 13 forks source link

Docs Getting Started Page #121

Closed mspence2 closed 4 years ago

mspence2 commented 5 years ago

Closes #153

codecov-io commented 5 years ago

Codecov Report

Merging #121 into master will increase coverage by 1.64%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
+ Coverage   70.69%   72.34%   +1.64%     
==========================================
  Files           8        8              
  Lines         215      282      +67     
==========================================
+ Hits          152      204      +52     
- Misses         63       78      +15
Impacted Files Coverage Δ
pytentiostat/reporter.py 70.58% <0.00%> (ø)
pytentiostat/config_reader.py 64.58% <0.00%> (+11.33%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3a440a9...0d8f342. Read the comment docs.

sbillinge commented 4 years ago

Make sure these merges close the issues. This can be done manually, but if you put closes #<issue number> into the description (the first comment box) of the PR then GitHub will automatically close the issue when the PR is merged. It does mean that the PR should close the issue, so it is bad to have multi-PR issues. These are better to be broken down into multiple issues. So the thread where Mike was saying "I will make a new PR for that", the best is if that last part of the job is put into a new issue (attached to the milestone) that can be closed by Mike's new PR.

On Thu, Apr 2, 2020 at 12:33 PM aplymill7 notifications@github.com wrote:

Merged #121 https://github.com/juami/pytentiostat/pull/121 into master.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/juami/pytentiostat/pull/121#event-3193025234, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAOWUI574MIX3FU5ZA2AYLRKS465ANCNFSM4JROJHBA .

-- Professor Simon Billinge Columbia University

aplymill7 commented 4 years ago

Good point! I retroactively added issues and linked the PR to them and subsequently closed them now. For the final one that adjusts formatting we will close issue 142 with it.