Open jlhitt1993 opened 3 years ago
Merging #162 (98224ff) into master (8cc4364) will increase coverage by
0.70%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #162 +/- ##
==========================================
+ Coverage 72.34% 73.04% +0.70%
==========================================
Files 8 8
Lines 282 282
==========================================
+ Hits 204 206 +2
+ Misses 78 76 -2
Impacted Files | Coverage Δ | |
---|---|---|
tests/test_config_reader.py | 78.94% <0.00%> (+10.52%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8cc4364...98224ff. Read the comment docs.
Hi @jlhitt1993, I don't see the pytent_env folder with a pytent_GUI.bat and a pytent_cmd.bat file in this pull request. Do you have these or are these not yet created? Just trying to figure out where you left off so we don't reinvent the wheel. Thanks!
Hey @pauchery I think there was initally one install_from_local
batch file for the flash drive that installed both the GUI and command line version located in the scripts folder, however it requires local copies of libraries in .whl format and it had a bug with the PyQt library that didn't work sometimes. It looks like that file is still in the scripts folder but you'll have to download the whl files for each library on their individual websites.
@jlhitt1993 ok thank you. We've been working with those .whl and batch files and got PySide2 to install with the batch file.
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 73.04%. Comparing base (
8cc4364
) to head (98224ff
). Report is 21 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
I updated the instructions for using the flash drive and removed the batch file for the old method. The new method will contain the batch file inside the env so no need for it here.