juami / pytentiostat

python code for the JUAMI potentiostat
BSD 3-Clause "New" or "Revised" License
9 stars 13 forks source link

Flash install #162

Open jlhitt1993 opened 3 years ago

jlhitt1993 commented 3 years ago

I updated the instructions for using the flash drive and removed the batch file for the old method. The new method will contain the batch file inside the env so no need for it here.

codecov-io commented 3 years ago

Codecov Report

Merging #162 (98224ff) into master (8cc4364) will increase coverage by 0.70%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
+ Coverage   72.34%   73.04%   +0.70%     
==========================================
  Files           8        8              
  Lines         282      282              
==========================================
+ Hits          204      206       +2     
+ Misses         78       76       -2     
Impacted Files Coverage Δ
tests/test_config_reader.py 78.94% <0.00%> (+10.52%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8cc4364...98224ff. Read the comment docs.

pauchery commented 2 years ago

Hi @jlhitt1993, I don't see the pytent_env folder with a pytent_GUI.bat and a pytent_cmd.bat file in this pull request. Do you have these or are these not yet created? Just trying to figure out where you left off so we don't reinvent the wheel. Thanks!

jlhitt1993 commented 2 years ago

Hey @pauchery I think there was initally one install_from_local batch file for the flash drive that installed both the GUI and command line version located in the scripts folder, however it requires local copies of libraries in .whl format and it had a bug with the PyQt library that didn't work sometimes. It looks like that file is still in the scripts folder but you'll have to download the whl files for each library on their individual websites.

pauchery commented 2 years ago

@jlhitt1993 ok thank you. We've been working with those .whl and batch files and got PySide2 to install with the batch file.

codecov-commenter commented 3 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.04%. Comparing base (8cc4364) to head (98224ff). Report is 21 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/juami/pytentiostat/pull/162/graphs/tree.svg?width=650&height=150&src=pr&token=KImmszfhlb&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juami)](https://app.codecov.io/gh/juami/pytentiostat/pull/162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juami) ```diff @@ Coverage Diff @@ ## master #162 +/- ## ========================================== + Coverage 72.34% 73.04% +0.70% ========================================== Files 8 8 Lines 282 282 ========================================== + Hits 204 206 +2 + Misses 78 76 -2 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/juami/pytentiostat/pull/162/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juami) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/juami/pytentiostat/pull/162?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juami). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juami) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/juami/pytentiostat/pull/162?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juami). Last update [8cc4364...98224ff](https://app.codecov.io/gh/juami/pytentiostat/pull/162?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juami). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juami).