In addition to being poorly named, this file currently serves two different functions. This file will be broken into two separate modules that are better named.
The first file that will be created will be reader_writer which will read and write voltages according to a given schedule including a startup routine for initial hold in addition to generated experiments. This one will also update real-time. Will change from globally editing data between functions in first file to reader_writer returning them after running a given schedule.
The second file will be scheduler which will generate time/voltage experiment schedules based on user input in the config file. This will then run reader_writer based on this schedule. As data will no longer be handled globally, will need to modify both files to accommodate previous data in the case of multiple read_write schedule needing to be passed (e.g. in the CV case). This file will also export the data once schedule complete.
I'll make a PR for this one after Implementing cycle number in cv is merged as I would like to incorporate those changes in the new files and will likely have many conflicts to resolve otherwise. I think should be independent of all other current PRs though aside from how they import the function, which should only affect main.
In addition to being poorly named, this file currently serves two different functions. This file will be broken into two separate modules that are better named.
The first file that will be created will be reader_writer which will read and write voltages according to a given schedule including a startup routine for initial hold in addition to generated experiments. This one will also update real-time. Will change from globally editing data between functions in first file to reader_writer returning them after running a given schedule.
The second file will be scheduler which will generate time/voltage experiment schedules based on user input in the config file. This will then run reader_writer based on this schedule. As data will no longer be handled globally, will need to modify both files to accommodate previous data in the case of multiple read_write schedule needing to be passed (e.g. in the CV case). This file will also export the data once schedule complete.
I'll make a PR for this one after Implementing cycle number in cv is merged as I would like to incorporate those changes in the new files and will likely have many conflicts to resolve otherwise. I think should be independent of all other current PRs though aside from how they import the function, which should only affect main.