juaml / hipsnp

handling SNP data, especially from UKB
https://juaml.github.io/hipsnp/
GNU Affero General Public License v3.0
0 stars 2 forks source link

[ENH] Improve `get_chromosomes_from_ensebml` code and logic #5

Open fraimondo opened 2 years ago

fraimondo commented 2 years ago

In get_chromosomes_from_ensebml https://github.com/juaml/hipsnp/blob/76963bfa47164baa2afaf41c55a0b72763c36578/hipsnp/hipsnp.py#L634

Problem: We currently do one request per RSID and parse the json in a not-so-good way.

We can improve this method by:

1- Using a combined request to ensembl.org REST API. 2- Checking the json response properly.

Todo: