juaml / julearn

Forschungszentrum Jülich Machine Learning Library
https://juaml.github.io/julearn
GNU Affero General Public License v3.0
30 stars 19 forks source link

[MAINT]: Prepare for scikit-learn 1.4 #244

Closed fraimondo closed 8 months ago

fraimondo commented 10 months ago

The first release candidate for scikit-learn 1.4 is available as from 21.12.2023.

We should test compatibility with julearn.

codecov[bot] commented 9 months ago

Codecov Report

Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 92.47%. Comparing base (8c908ce) to head (ada4534).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/juaml/julearn/pull/244/graphs/tree.svg?width=650&height=150&src=pr&token=VT2P05ZJCB&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://app.codecov.io/gh/juaml/julearn/pull/244?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #244 +/- ## ========================================== - Coverage 92.49% 92.47% -0.03% ========================================== Files 56 56 Lines 2679 2685 +6 Branches 482 482 ========================================== + Hits 2478 2483 +5 - Misses 129 130 +1 Partials 72 72 ``` | [Flag](https://app.codecov.io/gh/juaml/julearn/pull/244/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [docs](https://app.codecov.io/gh/juaml/julearn/pull/244/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `100.00% <ø> (ø)` | | | [julearn](https://app.codecov.io/gh/juaml/julearn/pull/244/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `92.47% <87.50%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/juaml/julearn/pull/244?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [julearn/pipeline/test/test\_target\_pipeline.py](https://app.codecov.io/gh/juaml/julearn/pull/244?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVsZWFybi9waXBlbGluZS90ZXN0L3Rlc3RfdGFyZ2V0X3BpcGVsaW5lLnB5) | `100.00% <100.00%> (ø)` | | | [julearn/base/estimators.py](https://app.codecov.io/gh/juaml/julearn/pull/244?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVsZWFybi9iYXNlL2VzdGltYXRvcnMucHk=) | `94.11% <85.71%> (-0.62%)` | :arrow_down: |
fraimondo commented 9 months ago

Docs are not building

synchon commented 9 months ago

Docs are not building

Yes I haven't completed this PR, hence didn't request a review yet.

github-actions[bot] commented 9 months ago

PR Preview Action v1.4.7 :---: Preview removed because the pull request was closed. 2024-03-06 17:10 UTC