Closed fraimondo closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 90.13%. Comparing base (
242982e
) to head (4cde6b8
).
PR Preview Action v1.4.7 :---: Preview removed because the pull request was closed. 2024-05-16 08:29 UTC
Since the current
OptunaSearchCV
has an issue with respect of scikit-learn's implementation (https://github.com/optuna/optuna-integration/issues/118), this PR includes an internal implementation which is fully compatible with scikit-learn.Particularly, the
fit
method uses a different study in each call, thus respecting the scikit-learn convention of learning in each call and overriding any previous fit call. The implementation in the optuna-integration package will continue training. This creates a test-to-train leakage when used with scikit-learn'scross_validate
function, which is also used by julearn.