juaml / julearn

Forschungszentrum Jülich Machine Learning Library
https://juaml.github.io/julearn
GNU Affero General Public License v3.0
30 stars 19 forks source link

[ENH] Remove final model fit requirement for inspector #270

Closed fraimondo closed 2 months ago

fraimondo commented 2 months ago

Currently, obtaining and inspector return_inspector=True requires that a final model is fit (return_estimator='all'). This is to be able to inspect the final model's parameters. Nevertheless, is not technically required if we need to inspect the fold-wise predictions.

This PR fixes that requirements, so either 'cv' or 'all' can be used, avoiding to fit final models on large complex models that can take up to hours.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.04%. Comparing base (be6a63b) to head (5e1e407). Report is 7 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/juaml/julearn/pull/270/graphs/tree.svg?width=650&height=150&src=pr&token=VT2P05ZJCB&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://app.codecov.io/gh/juaml/julearn/pull/270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #270 +/- ## ======================================= Coverage 90.03% 90.04% ======================================= Files 54 54 Lines 2429 2430 +1 Branches 492 493 +1 ======================================= + Hits 2187 2188 +1 Misses 159 159 Partials 83 83 ``` | [Flag](https://app.codecov.io/gh/juaml/julearn/pull/270/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [docs](https://app.codecov.io/gh/juaml/julearn/pull/270/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `100.00% <ø> (ø)` | | | [julearn](https://app.codecov.io/gh/juaml/julearn/pull/270/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `90.03% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/juaml/julearn/pull/270?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [julearn/api.py](https://app.codecov.io/gh/juaml/julearn/pull/270?src=pr&el=tree&filepath=julearn%2Fapi.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVsZWFybi9hcGkucHk=) | `95.20% <100.00%> (+0.03%)` | :arrow_up: | | [julearn/pipeline/pipeline\_creator.py](https://app.codecov.io/gh/juaml/julearn/pull/270?src=pr&el=tree&filepath=julearn%2Fpipeline%2Fpipeline_creator.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#diff-anVsZWFybi9waXBlbGluZS9waXBlbGluZV9jcmVhdG9yLnB5) | `86.47% <ø> (ø)` | |
github-actions[bot] commented 2 months ago

PR Preview Action v1.4.7 :---: Preview removed because the pull request was closed. 2024-09-04 11:17 UTC

synchon commented 2 months ago

Also the docs are failing to build, unrelated issue?