juaml / junifer

Forschungszentrum Jülich Neuroimaging Feature Extractor
https://juaml.github.io/junifer
GNU Affero General Public License v3.0
14 stars 13 forks source link

[ENH]: Add support for on-the-fly template space transformation #299

Closed synchon closed 7 months ago

synchon commented 9 months ago

This PR adds support for on-the-fly template space transformation in junifer.data.get_parcellation() and junifer.data.get_mask() enabling merging of multi-space parcellation and mask. The target space is set as per the datagrabber's specification and all of the other assets are transformed to it and then applied.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (e82603f) to head (78d63d6).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/juaml/junifer/pull/299/graphs/tree.svg?width=650&height=150&src=pr&token=5H21JuZXMw&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)](https://app.codecov.io/gh/juaml/junifer/pull/299?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) ```diff @@ Coverage Diff @@ ## main #299 +/- ## ============================================ + Coverage 88.15% 100.00% +11.84% ============================================ Files 111 1 -110 Lines 4820 1 -4819 Branches 957 0 -957 ============================================ - Hits 4249 1 -4248 + Misses 417 0 -417 + Partials 154 0 -154 ``` | [Flag](https://app.codecov.io/gh/juaml/junifer/pull/299/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | Coverage Δ | | |---|---|---| | [docs](https://app.codecov.io/gh/juaml/junifer/pull/299/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `100.00% <ø> (ø)` | | | [junifer](https://app.codecov.io/gh/juaml/junifer/pull/299/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml#carryforward-flags-in-the-pull-request-comment) to find out more. [see 110 files with indirect coverage changes](https://app.codecov.io/gh/juaml/junifer/pull/299/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=juaml)
synchon commented 9 months ago

Needs to go after #298

github-actions[bot] commented 8 months ago

PR Preview Action v1.4.7 :---: Preview removed because the pull request was closed. 2024-04-03 16:19 UTC

synchon commented 7 months ago

@fraimondo Can we merge this?

fraimondo commented 7 months ago

@synchon Just that one question.