Closed synchon closed 5 months ago
PR Preview Action v1.4.7 :---: Preview removed because the pull request was closed. 2024-03-14 14:31 UTC
Attention: Patch coverage is 78.23529%
with 74 lines
in your changes are missing coverage. Please review.
Project coverage is 88.55%. Comparing base (
5540b36
) to head (8bf68ac
).
Can you also update
docs/extending/markers.rst
? Maybe create a small section on "dependencies" and then refer to that?This way, we will document everything that is happening on this PR (which was also a bit undocumented before)
I'm already updating the docs for the release at https://github.com/juaml/junifer/tree/update/improve-docs . Will address your suggestions there along with a few more things that I noticed aren't there.
This PR improves the external dependency handling of
PipelineStepMixin
derived objects like Markers and Preprocessors. It adds a new class variable called_CONDITIONAL_DEPENDENCIES
which interact with_DEPENDENCIES
and_EXT_DEPENDENCIES
. This enables easy validation and usage of objects which have multiple implementations likeReHo
,ALFF
andBOLDWarper
. It also sets a nice foundation for similar objects in the future as will be implemented in #161 and #301. It also refactors internal code wherever required.