search

juan-leon / lowcharts

Tool to draw low-resolution graphs in terminal
MIT License
200 stars 5 forks source link

add percentiles to summary output #59

Closed JackKCWong closed 7 months ago

JackKCWong commented 7 months ago
image

I change the Stat::new to mutable borrow the input vec to avoid copying, except for the xyplot where original order matters. Let me know what you think. Cheers.

JackKCWong commented 7 months ago

tests passed.

image
juan-leon commented 7 months ago

Thanks for the pull request. Having percentiles is nice.

The Test pipeline failed (it seems fixable with cargo fmt).

If you have make tool installed you can do make pre-commit to make sure changes are OK. Otherwise, this will do the job:

cargo fmt -- --check
cargo test -- --test-threads 1
cargo clippy -- -D clippy::all
JackKCWong commented 7 months ago

cargo fmt -- --check

Should have run make pre-commit! Fixed now. Thanks.

juan-leon commented 7 months ago

Excellent!

Thanks for your contribution

juan-leon commented 7 months ago

Created release v0.5.9 with this change