search

juanca / react-aria-components

React ARIA-compliant Components
https://juanca.github.io/react-aria-components
MIT License
6 stars 3 forks source link

Tabs folder #14

Closed ahuth closed 6 years ago

ahuth commented 6 years ago

For https://github.com/devtools-html/debugger.html/pull/6595, this puts the tabs in their own folder.

There are some nice things about the components list being flat, but if we put a lot more of these in there it could get unwieldy. Particularly as we get more stylesheets and tests and whatnot.

And the main point of this is so that we can do:

import { Tabs, TabList, Tab, TabPanels } from 'react-aria-components/src/tabs';

Do you you think something like this is reasonable, @juanca? I can also see widget folders being nice if we ever want to do #8 and release each one individually.

juanca commented 6 years ago

For posterity's sake: LGTM.

It is reasonable to start grouping our components into folders.

This most likely will facilitate releasing each component as its own package. There are some concerns about sharing sub-components between these top-level components but there is most likely an appropriate solution despite our groupings.