juanca / react-aria-components

React ARIA-compliant Components
https://juanca.github.io/react-aria-components
MIT License
6 stars 3 forks source link

Grid V2 #46

Closed juanca closed 5 years ago

juanca commented 5 years ago

After some deliberation, I am starting to refactor the Grid (and its sub-components). The active index will be mainly managed by the Grid. Ideally this avoids the mess of determining where the focus came from -- which essentially becomes a duplicated responsibility across all grid cells.

I'm also going to aim for decoupling the keyboard accessibility from the type of component. Hopefully this will make it easier to make new accessible components: Grid (2D) -> List (1D) and their derivatives.

Bonus: I am also implementing a testing environment in Jest. I was waiting on finding a really good test utility for accessibility (e.g. end-to-end tests by driving a browser) but that seems to be stalled. The tests can at least provide some degree of confidence on keyboard and pointer interactions.

ahuth commented 5 years ago

🍾 Nice job merging this thing in!

juanca commented 5 years ago

Thanks! I ended up deprecating the previous table to build a new one with the Cursor as the underlying focus management tooling. That will be the upcoming project for this library -- and will work towards releases for feature parity.