search

juanca / react-aria-components

React ARIA-compliant Components
https://juanca.github.io/react-aria-components
MIT License
6 stars 3 forks source link

CoreJS is missing #67

Open juanca opened 5 years ago

juanca commented 5 years ago

Babel warns when corejs is missing from the configuration.

juanca commented 5 years ago

This is only needed once we upgrade to Babel@7.4.0 or higher. See https://babeljs.io/blog/2019/03/19/7.4.0

On that note, it is probably worthwhile to start using core-js@3 and testing on our desired target browsers.

It would be nice to investigate how to collect metrics on the bundle size of our application in dev / production mode with the different core-js versions.

While we assume host applications will configure their own Babel compilation, we can at least provide a baseline for inquiring minds.

roblevintennis commented 5 years ago

Maybe https://github.com/juanca/react-aria-components/pull/72 helps here?

Well, besides:

It would be nice to investigate how to collect metrics on the bundle size of our application in dev / production mode with the different core-js versions.

which might be another effort and/or issue?