Closed lonefelidae16 closed 1 year ago
I will end my commit with this comment for now.
Works fine for me (and I enjoying on my server), but there are still issues:
Sorry for the many commits. If I should squash these, it doesn’t matter to combine them into a reasonable amount of granularity. But please note, it needs to FORCE push with -f
option.
Please let me know if you have any further suggestions.
Hey! Sorry for the late response. I'll be testing this implementation and its differences with the previous one this week
Thank you! Whenever you’re ready.
Looks good! I think that the remaining issues are not as noticeable, and is a comprehensible compromise for having item animations client-side.
Thank you.
close #206
Bobbing animation with S2C network interaction. It also works when played on a vanilla server.
Known issues
ClientPlayerInteractionManager#interactItem
returnsActionResult.SUCCESS
and decreasing in stack.~ edit: Solved in commit: c2395f621c8bf7c71aad0ddf25f59152127f7bfe and da10b9d8459c6ce17f34f178955a124481b0489a.LivingEntity
and handle it inClientPlayerEntity
, but this solution doesn’t work on a vanilla server. Also, there may be a conflict in the magic number of the statuses in a future update.