juancarloscp52 / BedrockIfy

A Minecraft mod that implements some Minecraft Bedrock features into Java edition.
GNU General Public License v3.0
178 stars 38 forks source link

[feat] Bedrock Sun Glare and Sky Color #224

Closed lonefelidae16 closed 1 year ago

lonefelidae16 commented 1 year ago

close #110

The feature of Bedrock Sun Glare and Sky Color. This is enabled by the sunlightIntensity value and bedrockShading option in the Visual Improvements settings.

Translation keys have been updated. Please check lang/en_us.json.


Behavior

This is disabled by default when the external shader is turned on. It cannot be forced to be enabled at the moment.

Use Reflection to detect whether the external shader is present or not.


Changes

lonefelidae16 commented 1 year ago

I know there is another way to inject into other mods that uses Pseudo annotation instead of Reflection. BedrockIfy has a great mechanism for applying Mixins provided by BedrockIfyMixinPlugin.java and it will make users can be forced to enable this feature regardless of whether the external shader is present.

If more flexibility is needed in the future version, this may be discussed as a way to also obtain the sun angle that is changed by the shaders.