search

juancarloscp52 / BedrockIfy

A Minecraft mod that implements some Minecraft Bedrock features into Java edition.
GNU General Public License v3.0
178 stars 38 forks source link

Hotbar animation error #244

Closed tianazhu closed 1 year ago

tianazhu commented 1 year ago

Version 1.19.4-bedrockify-1.7.1 When a tool with enchanting unbreaking is used, the usage animation is always played instead of when the durability is consumed.

tianazhu commented 1 year ago

There is also in the use of fireworks rocket flight when playing animation too fast

tianazhu commented 1 year ago

Screenshot demo This also affects the creative mode 2023-03-23_08 39 30

screenshot_demo

lonefelidae16 commented 1 year ago

Hi! Thank you for your reporting. This is due to #207 , and its spec.

I cannot confirm the original Bedrock spec, but is this the ”wrong” implementation?

If you think so, the animation can also be limited to only when durability is reduced.

tianazhu commented 1 year ago

Hi! Thank you for your reporting. This is due to #207 , and its spec.

I cannot confirm the original Bedrock spec, but is this the ”wrong” implementation?

If you think so, the animation can also be limited to only when durability is reduced.

Previous older versions did not have this problem But after installing bedrockify-1.7.1 there is a problem.

lonefelidae16 commented 1 year ago

It seems that a spec I implemented as a good idea has turned out to be a problem. Sorry about that.

I will create a new PR so that we can revert to the old version of the spec.