juancarloscp52 / BedrockIfy

A Minecraft mod that implements some Minecraft Bedrock features into Java edition.
GNU General Public License v3.0
167 stars 37 forks source link

[Issue] Disable Flying Momentum resets on game restart #257

Closed bernards934 closed 1 year ago

bernards934 commented 1 year ago

Versions

Explanation

The "Disable Flying Momentum" setting parameter resets to OFF when you start the game. The setting value is not saved upon restart.

Technical observations

The bedrockifyClient.json config file DOES contain the right value for the key disableFlyingMomentum but it still appears as Disabled in the in-game mod settings :

{
    // ...
    "disableFlyingMomentum":true
    // ...
}

Here is the full bedrockifyClient.json file content :

{"loadingScreen":false,"bedrockIfyButton":false,"showPositionHUD":false,"FPSHUD":0,"heldItemTooltip":0,"showPaperDoll":false,"showChunkMap":false,"reacharound":true,"reacharoundSneaking":true,"reacharoundIndicator":true,"reacharoundMultiplayer":true,"positionHUDHeight":50,"screenSafeArea":0,"overlayIgnoresSafeArea":false,"cubeMapBackground":false,"bedrockChat":false,"slotHighlight":true,"highLightColor1":-1,"highLightColor2":-9590208,"idleAnimation":1.0,"reacharoundBlockDistance":0.5,"reacharoundPitchAngle":25,"savingOverlay":false,"eatingAnimations":true,"expTextStyle":false,"quickArmorSwap":true,"transparentHotBar":true,"biggerIcons":true,"sneakingShield":true,"bedrockShading":false,"disableFlyingMomentum":true,"elytraStop":true,"panoramaIgnoredScreens":[".modmenu.gui.ModsScreen",".iris.gui.",".modmanager.gui.","yacl.gui.YACLScreen"]}
juancarloscp52 commented 1 year ago

Than you for the detailed issue description, I'll take a look at it in the following days ;)

juancarloscp52 commented 1 year ago

Hello! I've been trying to replicate your issue, but I haven't been able to do so. Here is what I've tried:

Start BedrockIfy with defualt settings:

Change disable flying momentum to Off in settings menu:

Changing disable flying momentum back to On:

Maybe i am missing something?

bernards934 commented 1 year ago

Well, I've just tried the following :

Also, the "RESET" button at the side is clickable and actually turns it ON.

Maybe I have a conflict with another mod, I'll try to disable everything I can and I keep you updated.

bernards934 commented 1 year ago

I found it, the issue appears with the MidnightControls mod. https://modrinth.com/mod/midnightcontrols

I am using version 1.7.4 of this mod.

bernards934 commented 1 year ago

Alright, I watched over all the settings of this other mod and there is "Fly drifting" parameter which does exactly the same thing, but if I set it to the same state than it is in Bedrockify, after reboot it's still disabled.

But anyway, I am not sure that's an issue for you to resolve. Sorry for issue report and for the time you may have spent looking for it..

juancarloscp52 commented 1 year ago

ok, I've checked and midnight controls implements compatibility with bedrockIfy. As they implement the same feature, the mod disables bedrockIfys drift on start up, thats why you see the setting resetting after restart. For adjusting the drift, modify it in midnight controls settings. Thank you for opening the issue anyways! :)