search

juancarloscp52 / BedrockIfy

A Minecraft mod that implements some Minecraft Bedrock features into Java edition.
GNU General Public License v3.0
167 stars 37 forks source link

Update BedrockifyClientSettings.java to avoid graphic glitch with simple voice mod #268

Closed Cape-City closed 1 year ago

Cape-City commented 1 year ago

There is a graphic glitch within the group screen of the simple voice mod from henkelmax. The glitch happens, if the setting for the "show panoramascreen" is activ in BedrockIfy. I figured out, if the entry "de.maxhenkel.voicechat" is added to the disabled list for the panorama setting, the issue is gone and the panorama setting can be keep enabled.

https://github.com/henkelmax/simple-voice-chat/issues/565

juancarloscp52 commented 1 year ago

Hello! Thank you for taking a look at the issue, but it was already fixed in bedrockify 1.8 in change:

[Fix] Prevent panorama background to applying to voicechat mod menus (fixes #246)by @juancarloscp52 in d820626

You can see that the modified file already contains ".voicechat.gui" and in that new version of bedrockIfy the issue no longer appears. I can see in the logs shared you are using bedrockIfy 1.6.1, which does not implement that fix. Please, when posible, update bedrockIfy.

image

If for any reason you cannot update because of using mc 1.19.3, in bedrockIfy settings, in "Panorama Screens", click the + icon on "Disable Panorama on screens:" and add .voicechat.gui. Hope this helps. And again thank you for taking the time although the changes won't merged.