[compat] Chat Heads - Githubissues

juancarloscp52 / BedrockIfy

A Minecraft mod that implements some Minecraft Bedrock features into Java edition.

GNU General Public License v3.0

180 stars 37 forks source link

[compat] Chat Heads #282

Closed lonefelidae16 closed 1 year ago

lonefelidae16 commented 1 year ago

fix #271

Tested on Minecraft 1.20 and 1.20.1.

Overhauled the mixin of ChatHud. This change is aimed at ChatHeads compatibility, but with other mods may also increase.

Passed the following cases:

[x] Move rendering area of ChatHud if Bedrock chat style is enabled.
[x] Render ChatHeads correctly.
[x] Show tooltip and Click behavior is fine.
[x] Contains Screen safe area feature.
[x] Contains Hud opacity feature when ChatHud doesn’t focus.

Changes

update chat.ChatHudMixin
- modify args instead of canceling render method
- injection method mouseClicked and getText have been removed
- new injection method bedrockify$calcChatLineX and bedrockify$calcChatLineY have been added

juancarloscp52 commented 1 year ago

Hello! First of all, sorry for the huge delay with the PRs and Issues. I've taken a long modding break in order to finish some IRL stuff. I'll go through the currently open PRs in the following days. Thank you for the PR, this change was really needed <3