[fix][compat] YetAnotherConfigLib

juancarloscp52 / BedrockIfy

A Minecraft mod that implements some Minecraft Bedrock features into Java edition.

GNU General Public License v3.0

180 stars 37 forks source link

[fix][compat] YetAnotherConfigLib #293

Closed lonefelidae16 closed 1 year ago

lonefelidae16 commented 1 year ago

fix #289

The namespace of YetAnotherConfigLib has changed since v3.

This change applies a check to TabButtonWidget and TabNavigationWidget to ignore cubemap rendering.

Changes

update client.BedrockifyClientSettings
- add entry yacl3.gui.YACLScreen to PANORAMA_IGNORED_SCREENS
- change method signature: panoramaIgnoreScreen(Screen) -> void
update panorama background:
- mixin.client.features.panoramaBackground.EntryListWidgetMixin
- mixin.client.features.panoramaBackground.ScreenMixin
- mixin.client.features.panoramaBackground.TabButtonWidgetMixin
- mixin.client.features.panoramaBackground.TabNavigationWidgetMixin

juancarloscp52 commented 1 year ago

Hello! I've been thinking of including my other mod Panorama Screens as a bundled lib. Panorama Screens uses a allowlist by default instead of a blocklist, so these kinds of problems wont happen again. Additionally, it adds an option to print in logs the names of screens which was coincidentally requested in #289

lonefelidae16 commented 1 year ago

Thanks for your reply!

I've been thinking of including my other mod Panorama Screens as a bundled lib. Panorama Screens uses a allowlist by default instead of a blocklist, so these kinds of problems wont happen again.

Sounds great! If the integration as a lib goes well, this changes should make conflicts. At that point I’ll close this so you can continue updating without worry. I sincerely thank you for your hard work :)

juancarloscp52 commented 1 year ago

Functionality fixed by replacing rotating background implementation with Panorama Screens mod in commit 55f61113d8a7cd289dd999124a6ac90c8cc413a8