Closed lonefelidae16 closed 2 months ago
Hey! thank you so much. I was checking the last weekend the updates needed for bedrockify and decided to wait a little bit in order to read the item components changes, but it would have definitively taken me a lot more to port haha. Thank you.
I'll be testing the PR in depth and checking, i expect to merge it by the end of the weekend at worse.
Haha, I think this update is really massive and makes developers cry. What’s the deal with adding 866 lines? I might commit when I notice codes that could be described more cleanly, or that I implemented without much thought.
I’ll also be installing on my dedicated server and doing some debugging play.
Will it keep the hotbar animation item usage animation. I don't see you mentioning this feature on here?
Will it keep the hotbar animation item usage animation. I don't see you mentioning this feature on here?
Oh, sorry. I just quoted from the README, so the basic functionality there will be maintained like HotBar animations, dragging item makes bigger, slot highlights. I'll update my comment.
@juancarloscp52 Sorry for the mention, but I received a new pull https://github.com/lonefelidae16/BedrockIfy/pull/2 , that adds a simple CI for all branches when pushing to repo.
Are you interested in setting up a CI/CD? I don’t need this, but it affects this pull, so I leave this comment. If the merge goes through as is, I’ll handle it on our side.
@juancarloscp52 Sorry for the mention, but I received a new pull lonefelidae16#2 , that adds a simple CI for all branches when pushing to repo.
Are you interested in setting up a CI/CD? I don’t need this, but it affects this pull, so I leave this comment. If the merge goes through as is, I’ll handle it on our side.
I was planning on having some Delivery pipeline to publish on curseforge and modrinth more easily for this next release (similar to the ones i have in spyglass-improvements or panorama-screens). For the CI, at the moment i dont see much point to having just a build pipeline with nothing else.
I've finished reviewing and testing all functionality! Great work! thank you so much 🙂
When will sun glare get fixed? because it's broken since like 1.20.2 and is one of my favorite features in this mod and there are no alternatives
When will sun glare get fixed? because it's broken since like 1.20.2 and is one of my favorite features in this mod and there are no alternatives
Sun Glare feature works for me (and also maybe Juan does since this is merged). Please provide details of your instance such as modlist, Fabric or Quilt, and its API version.
Similar issue is here #324
Sun Glare feature works for me (and also maybe Juan does since this is merged). Please provide details of your instance such as modlist, Fabric or Quilt, and its API version.
Similar issue is here #324
I tried disabling Iris mod and sun glare started working, I think that code in BedrockIfy which detects whenever custom iris shaders are enabled or disabled is broken since like 1.20.2, because on 1.20.1 sun glare works even if iris is installed and disables itself only if custom shaders are enabled but on 1.20.4 and 1.20.6 at least, sun glare disables itself whenever Iris mod is installed even if custom shaders are not enabled.
Hi, long time no see 👋
Soooo many breaking changes are here, and unfortunately Mojang started to support the same feature as the Panorama Screens mod. I’m sad.
If I check them one by one, I’d run out of time, so I’ll pick up only the features that I’ve checked. I’ll make a pull each time I find a bug.
close #334
...Is that about right?
The ~crazy amount of~ Changes
Dependency Updates:
NBT Tag has been replaced by Component:
Particle Spawn System has been replaced by Payload System:
client.payloads.*
~ moved tocommon.payloads.*
Part of ActionResult has been split into ItemActionResult.
Update mixins.
Update recipes.
Update WorldGen datapacks.