Closed lonefelidae16 closed 2 weeks ago
I’ll move this pull to draft as I found a few things I wanna try regarding the Cauldron feature I mentioned in #350 .
From the logs:
server
LOGGER.info("item tags check: WOLF_ARMOR.isIn(ItemTags.DYEABLE) = {}", Items.WOLF_ARMOR.getDefaultStack().isIn(ItemTags.DYEABLE));
// got "item tags check: WOLF_ARMOR.isIn(ItemTags.DYEABLE) = true"
client
LOGGER.info("item tags check: WOLF_ARMOR.isIn(ItemTags.DYEABLE) = {}", Items.WOLF_ARMOR.getDefaultStack().isIn(ItemTags.DYEABLE));
// got "item tags check: WOLF_ARMOR.isIn(ItemTags.DYEABLE) = false"
These filter gets the empty result on the Client.
And returns ActionResult.PASS
in ClientPlayerInteractionManager#interactBlock
due to the default return value ItemResult.PASS_TO_DEFAULT_BLOCK_INTERACTION
defined in CauldronBehavior#createMap
.
I avoided hardcoding in consideration of other Mods and data packs, but it seems difficult to get the ItemTags on the Client. I’m looking for a way to break the ice...
I guess I was thinking too hard haha. Just replace registration point with ClientPlayConnectionEvents.JOIN
will fix. Everything works.
Hi, I brought 1.21 compatibility code.
Changes
SunGlare feature:
updateAngleDiff
SavingOverlay feature:
EatingAnimations feature:
Thanks for all your work!