search

juancarlosfarah / apero

A preprocessing pipeline builder for neuroimaging data.
MIT License
4 stars 0 forks source link

test: add correctslicetiming test #29

Closed hannatolle closed 2 years ago

hannatolle commented 2 years ago

The test runs. However, I wonder if we should change line 70 in the CorrectSliceTiming.m opertion to this here: ocustomfile = fullfile(pathToWorkspace, config.ocustom) command = sprintf('%s --ocustom %s', command, ocustomfile); In that case, I'd need to adjust the test as well.

Also, I read (here: https://zims-en.kiwix.campusafrica.gos.orange.com/wikibooks_en_all_maxi/A/Neuroimaging_Data_Processing/Slice_Timing) that the ocustom file should be a text file. Is the .txt extension correct?

juancarlosfarah commented 2 years ago

@hannatolle regarding your questions:

  1. Indeed we need to make that change. Good catch!
  2. The extension doesn't really, matter. It just needs to have a text encoding, I would assume. But it's good to put the .txt as an extension to be explicity.