juancarlospaco / faster-than-requests

Faster requests on Python 3
https://gist.github.com/juancarlospaco/37da34ed13a609663f55f4466c4dbc3e
MIT License
1.09k stars 91 forks source link

Add wheel to the installation requirement #202

Closed Letme closed 1 year ago

Letme commented 1 year ago

If you do not have wheel installed the library installation fails.

Closes #189

I cant really test this, since there is no setup.py in the root of the repo, so commands like: pip3 install git+https://github.com/Letme/faster-than-requests.git@patch-1 fail, but it would be cool to support them. Also I would never commit the artifacts (in here they are in dists folder) since they are created by build (and now you invented script to delete them and stuff). Anyway all that is part of the architecture decision, so if you want me to improve that I can probably dig into it, but until then I let you test this fix - which should install wheel before installing the library (otherwise it does not work).

juancarlospaco commented 1 year ago

The problem is that the code in the repo does not really depends on wheel at all, if PIP depends on wheel to work properly, go open a bug to PIP, I can not fix PIP sorry.

We are working on another repo to fix this, to workaround PIP bugs.

Letme commented 1 year ago

I thought you want easy installation, not for us to report bugs on pip. Many libraries package just fine, so not sure why this bug is so specific to you or why you do not want to switch to same packaging system everyone else does. But number of open issues tell you this is the problem, I can also tell you it was a problem for me.

From simple pip install to import to use the library function call, I spent 30 minutes to install, and now it does not work in tox, because of same things which are described in your issues. Not to mention that when I clicked star, it automatically puts a commit to the repository which boosts activity, but also makes me a contributor (kinda involuntary).

juancarlospaco commented 1 year ago

I cant really test this

You literally confirmed that no one tested if this even works, I can not merge this then... 🤷

Letme commented 1 year ago

Do as you wish. I was trying to help.