juancarlospaco / plz

PLZ Python PIP Alternative
MIT License
40 stars 6 forks source link

Compilation error on nim 1.6.8 / 1.6.10 #8

Closed kunitoki closed 1 year ago

kunitoki commented 1 year ago
/Users/kunitoki/nim/plz/src/plz/docgen.nim(21, 36) Error: type mismatch: got <string, string, int literal(1), int literal(1), bool, set[RstParseOption]>
but expected one of:
proc rstParse(text, filename: string; line, column: int;
              options: RstParseOptions; findFile: FindFileHandler = nil;
              msgHandler: MsgHandler = nil): tuple[node: PRstNode,
    filenames: RstFileTable, hasToc: bool]
  first type mismatch at position: 5
  required type for options: RstParseOptions
  but expression 'option' is of type: bool

expression: rstParse(readFile(filename), "", 1, 1, option,
         {roSupportSmilies, roSupportRawDirective, roSupportMarkdown})
     Error: Build failed for package: plz
        ... Execution failed with exit code 256
        ... Command: /Users/kunitoki/.nimble/bin/nim c --colors:on --noNimblePath -d:NimblePkgVersion=0.0.1 -o:/Users/kunitoki/nim/plz/plz /Users/kunitoki/nim/plz/src/plz.nim
juancarlospaco commented 1 year ago

I am also interested in making it compatible with >= 2.0 because it has some interesting features that make the code better and safer.

juancarlospaco commented 1 year ago

Fixed. Give it a try and let me know any comments.

kunitoki commented 1 year ago

Awesome thanks ! will give it a spin

kunitoki commented 1 year ago

https://github.com/juancarlospaco/plz/pull/10