fix two problem makes demo actually works fine on macos

juancarlospaco / webgui

Web Technologies based Crossplatform GUI Framework with Dark theme

https://juancarlospaco.github.io/webgui

MIT License

140 stars 8 forks source link

fix two problem makes demo actually works fine on macos #10

Closed bung87 closed 4 years ago

bung87 commented 4 years ago

fix webview_eval on macos replace original simple solution
dataUriHtmlHeader as proc,using base64 follow w3c rules make it actually works on macos without side effect

juancarlospaco commented 4 years ago

Please dont touch dataUriHtmlHeader dont break the API, also base64 is different from plain-text, make another dataUriBase64Header* template, other OS should not break for this, use when defined(osx): as needed, "data:text/html;charset=utf-8,<h1>Hello" on URL just works for Linux without Base64 overhead, the rest is Ok, but please make that change so I can merge. :slightly_smiling_face:

bung87 commented 4 years ago

Can I make dataUriHtmlHeader also as proc, I cant figure out a way using & and proc, and when reading html file, content contains line breaks, I don't think that's fine with data:

juancarlospaco commented 4 years ago

Yes, make it a template use when defined(osx): as needed.

The point is other OS should be able to use plain-text because it works there.

Thanks very much!.